docker: add manifest to versioned docker releases#11268
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Can you also fix https://github.com/sgl-project/sglang/blob/main/docker/Dockerfile#L102 to add another OR condition for |
|
Another issue is this (https://github.com/sgl-project/sglang/blob/main/docker/Dockerfile#L143-L149) will fail if CUDA_VERISON=12.6.1. |
.github/workflows/release-docker.yml
Outdated
| docker buildx build --platform linux/arm64 --push -f docker/Dockerfile --build-arg CUDA_VERSION=${{ matrix.variant.cuda_version }} --build-arg BUILD_TYPE=${{ matrix.variant.build_type }} -t lmsysorg/sglang:${tag}${tag_suffix} --no-cache . | ||
| # Create versioned manifest | ||
| docker buildx imagetools create \ | ||
| -t lmsysorg/sglang:v${version}-cu129 \ |
There was a problem hiding this comment.
we don't need -cu129 suffix
There was a problem hiding this comment.
maybe still keep it somewhere?
Later we might have -cu129, -cu130 , which cannot be unified.
but for lmsys/sglang:latest, we can remove it and have a default cuda verison
There was a problem hiding this comment.
e.g.
lmsysorg/sglang:v0.5.3 for cu129
lmsysorg/sglang:v0.5.3-cu130 for cu130
how about this
There was a problem hiding this comment.
This makes sense. I think default for almost all users will be cu129 therefore we don't need it. As we push on cu130 lets keep it tagged as such
There was a problem hiding this comment.
I am actually worried that users may be troubled, for example, this image can also be used on cu126/cu128/cu129 hopper, not just cu129.
Goal is to run
docker pull lmsysorg/sglang:v0.5.3and get the proper image corresponding to your machine. Also added in alatestas well @zhyncs