Skip to content

Rename max_micro_batch_size -> pp_max_micro_batch_size#11279

Merged
merrymercy merged 1 commit intomainfrom
lianmin/sync-server-arg-change
Oct 6, 2025
Merged

Rename max_micro_batch_size -> pp_max_micro_batch_size#11279
merrymercy merged 1 commit intomainfrom
lianmin/sync-server-arg-change

Conversation

@merrymercy
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @merrymercy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and explicitness of a key configuration parameter related to pipeline parallelism. By renaming max_micro_batch_size to pp_max_micro_batch_size, the change ensures that the parameter's scope and purpose are immediately clear, reducing potential ambiguity for developers and enhancing the maintainability of the system's distributed training configurations.

Highlights

  • Parameter Renaming: The max_micro_batch_size parameter has been consistently renamed to pp_max_micro_batch_size across the codebase to explicitly indicate its association with pipeline parallelism.
  • Documentation Update: The documentation for server arguments (docs/advanced_features/server_arguments.md) has been updated to reflect the new parameter name.
  • Codebase Consistency: All relevant code files, including http_server.py, schedule_batch.py, scheduler.py, and server_args.py, have been modified to use the new pp_max_micro_batch_size parameter name, ensuring consistency in argument parsing, internal logic, and API examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly renames max_micro_batch_size to pp_max_micro_batch_size to better signify its connection to pipeline parallelism. The change has been consistently applied across all relevant files, including documentation, code comments, argument definitions, and its usage in the scheduler logic. The refactoring is clean and improves code clarity. I have no further comments.

@merrymercy merrymercy merged commit 708f4ff into main Oct 6, 2025
38 of 67 checks passed
@merrymercy merrymercy deleted the lianmin/sync-server-arg-change branch October 6, 2025 22:50
ch-tiger1 pushed a commit to ch-tiger1/sglang that referenced this pull request Oct 9, 2025
lpc0220 pushed a commit to lpc0220/sglang that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments