Conversation
This commit updates the sgl-kernel version across all relevant files:
- sgl-kernel/pyproject.toml
- sgl-kernel/pyproject_cpu.toml
- sgl-kernel/pyproject_rocm.toml
- sgl-kernel/python/sgl_kernel/version.py
🤖 Generated with GitHub Actions
Summary of ChangesHello @sglang-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance task by updating the version number of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR bumps the sgl-kernel version to 0.3.15. The version is updated correctly across the modified files. However, I've identified a potential issue with the release automation. The script scripts/release/bump_kernel_version.py lists docker/Dockerfile as a file to be updated, but this file is not included in the PR's changes. This could lead to an inconsistent version in the Docker image, so I've left a comment suggesting to update all relevant files.
| @@ -1 +1 @@ | |||
| __version__ = "0.3.14.post1" | |||
| __version__ = "0.3.15" | |||
There was a problem hiding this comment.
While the version is correctly updated in this file, the release script scripts/release/bump_kernel_version.py also lists docker/Dockerfile for update. However, docker/Dockerfile was not modified in this pull request. This omission could lead to inconsistent versioning in the Docker image. Please ensure all files listed in the release script are updated accordingly.
Summary
This PR bumps the sgl-kernel version to
0.3.15across all relevant files.Files Updated
🤖 Generated with GitHub Actions