Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the observability and manageability of the SGLang gRPC scheduler by adding dedicated endpoints to query its operational state. Clients can now programmatically retrieve detailed information about the deployed model and the server's current configuration and runtime metrics, facilitating better monitoring, debugging, and integration with external systems. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two new gRPC endpoints, GetModelInfo and GetServerInfo, to expose model and server information. The changes include updating the protobuf definitions and implementing the corresponding servicer methods. The implementation is mostly correct, but I've found an issue in the serialization logic for server arguments which could lead to malformed data for fields containing sets. My feedback includes a suggestion to fix this.
Changes
Note
internal state is purposely ignored in get server info
this will be streamed back in each token generation in the future
Validations
grpcurl -plaintext localhost:30000 sglang.grpc.scheduler.SglangScheduler/GetModelInfo { "model_path": "/raid/models/meta-llama/Llama-3.1-8B-Instruct", "tokenizer_path": "/raid/models/meta-llama/Llama-3.1-8B-Instruct", "is_generation": true, "weight_version": "default", "served_model_name": "/raid/models/meta-llama/Llama-3.1-8B-Instruct", "max_context_length": 414382, "vocab_size": 128256, "model_type": "transformer", "bos_token_id": 1, "max_req_input_len": 131066 }Checklist