Skip to content

[router] fix grpc connection conversion and add optimization#11305

Merged
slin1237 merged 7 commits intomainfrom
grpc-endpoint
Oct 7, 2025
Merged

[router] fix grpc connection conversion and add optimization#11305
slin1237 merged 7 commits intomainfrom
grpc-endpoint

Conversation

@slin1237
Copy link
Collaborator

@slin1237 slin1237 commented Oct 7, 2025

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the gRPC client's connection handling within the router. It streamlines the process of converting gRPC endpoint URLs and, more significantly, implements a suite of optimizations for the underlying gRPC connections to improve their reliability and throughput.

Highlights

  • gRPC Endpoint Conversion: Simplified the conversion of 'grpc://' endpoints to 'http://' by using direct string replacement, removing the more complex URL parsing logic and associated warning.
  • gRPC Connection Optimizations: Introduced several 'tonic' channel configurations to enhance gRPC connection stability and performance, including HTTP/2 keep-alive, TCP keep-alive, TCP no-delay, adaptive windowing, and increased initial stream/connection window sizes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with gRPC endpoint string conversion and adds several performance optimizations to the tonic channel configuration. The changes are a good improvement.

I've left two comments:

  1. A high-severity issue with the use of String::replace for changing the URL scheme, which could lead to invalid URLs. I've suggested using strip_prefix for a safer implementation.
  2. A medium-severity suggestion to extract the new hardcoded channel configuration values into named constants to improve code readability and maintainability.

@slin1237 slin1237 added the router label Oct 7, 2025
@slin1237 slin1237 merged commit f4affd4 into main Oct 7, 2025
60 of 67 checks passed
@slin1237 slin1237 deleted the grpc-endpoint branch October 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments