Skip to content

[Doc] Update mooncake nvlink transport doc for PD disaggregation#11321

Merged
zhyncs merged 2 commits intosgl-project:mainfrom
kvcache-ai:fix_nvlink_doc
Oct 8, 2025
Merged

[Doc] Update mooncake nvlink transport doc for PD disaggregation#11321
zhyncs merged 2 commits intosgl-project:mainfrom
kvcache-ai:fix_nvlink_doc

Conversation

@ShangmingCai
Copy link
Collaborator

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Signed-off-by: Shangming Cai <csmthu@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ShangmingCai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR updates the documentation for Mooncake NVLink transport within the PD disaggregation guide. It adds instructions for configuring environment variables (SGLANG_MOONCAKE_CUSTOM_MEM_POOL and MC_FORCE_MNNVL) required for NVL72 deployments.

Highlights

  • Intent: This pull request updates the documentation for Mooncake NVLink transport, specifically for PD disaggregation, to include necessary configuration for NVL72 deployments.
  • Key Changes: A new section titled 'NVLink Transport Configuration' has been added to docs/advanced_features/pd_disaggregation.md. This section instructs users to set SGLANG_MOONCAKE_CUSTOM_MEM_POOL=True and MC_FORCE_MNNVL=True when utilizing NVLink transport with the Mooncake backend for NVL72 deployments.
  • Reviewer Activity: No specific reviewer activity has been noted yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for PD disaggregation to include configuration for NVLink transport with the Mooncake backend. The change is clear and well-placed within the document. I have one suggestion to improve the accuracy of the description based on the provided source code.

Signed-off-by: Shangming Cai <csmthu@gmail.com>
@zhyncs zhyncs merged commit 0a7c4bd into sgl-project:main Oct 8, 2025
26 checks passed
ch-tiger1 pushed a commit to ch-tiger1/sglang that referenced this pull request Oct 9, 2025
lpc0220 pushed a commit to lpc0220/sglang that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments