[router] Support history management using conversation#11339
Merged
slin1237 merged 9 commits intosgl-project:mainfrom Oct 8, 2025
Merged
[router] Support history management using conversation#11339slin1237 merged 9 commits intosgl-project:mainfrom
slin1237 merged 9 commits intosgl-project:mainfrom
Conversation
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces basic conversation support, which is a significant feature. The implementation looks solid, with both in-memory and Oracle database storage for conversation items. I've identified a few areas for improvement, mainly around code clarity, efficiency, and robustness in error handling. Addressing these points will enhance the maintainability and reliability of this new functionality. Great work on this feature!
sgl-router/src/data_connector/conversation_item_memory_store.rs
Outdated
Show resolved
Hide resolved
sgl-router/src/data_connector/conversation_item_oracle_store.rs
Outdated
Show resolved
Hide resolved
sgl-router/src/data_connector/conversation_item_oracle_store.rs
Outdated
Show resolved
Hide resolved
ch-tiger1
pushed a commit
to ch-tiger1/sglang
that referenced
this pull request
Oct 9, 2025
lpc0220
pushed a commit
to lpc0220/sglang
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support using conversation to manage the response history.
This PR:
Modifications
Tests
conversation item table:

conversation item links table:

Tested both Oracle db and memory. Here is an example of oracle db result
Benchmarking and Profiling
Checklist