Update sgl-kernel and remove fast hadamard depedency

[Fridge003]

Motivation

Follow up of #11663 and #11733

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

[gemini-code-assist]

Summary of Changes

Hello @Fridge003, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's dependencies by eliminating the external fast-hadamard-transform library. The functionality previously provided by this library has been replaced by an internal implementation within the sgl_kernel module. This change simplifies the project's build environment, reduces reliance on third-party repositories, and improves overall maintainability by consolidating core functionalities.

Highlights

• Dependency Removal: The external fast-hadamard-transform library has been completely removed from the project's dependencies.
• Internal Implementation: The Hadamard transform functionality is now sourced from sgl_kernel.hadamard, indicating a shift to an internal or re-packaged implementation.
• Build Process Streamlining: The Dockerfile and CI installation scripts have been updated to reflect the removal of the external dependency, simplifying the build and continuous integration processes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively removes the fast-hadamard-transform dependency by vendoring its functionality into sgl-kernel. The modifications to the Dockerfile, CI scripts, and Python source code are correct and align with the PR's objective. My review includes one suggestion for improving code style. Additionally, for further cleanup, the FAST_HADAMARD_TRANSFORM_COMMIT build argument in docker/Dockerfile is now obsolete and can be removed.

[gemini-code-assist]

To improve code style and adhere to PEP 8, it's recommended to move this import statement to the top of the file with the other imports. Local imports within functions should generally be avoided unless necessary to prevent circular dependencies or for optional packages. Since sgl_kernel is now an internal part of the project, moving the import to the top level would be cleaner.¹

Style Guide References

Footnotes

1. PEP 8: E402 module level import not at top of file. Imports should usually be at the top of the file. ↩