Skip to content

Install numactl in Dockerfile for GH200/GB200/GB300#11853

Merged
Fridge003 merged 3 commits intomainfrom
fzyzcjy-patch-4
Oct 24, 2025
Merged

Install numactl in Dockerfile for GH200/GB200/GB300#11853
Fridge003 merged 3 commits intomainfrom
fzyzcjy-patch-4

Conversation

@fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Oct 20, 2025

Motivation

it has NUMA memory by default, thus we may need a numactl to avoid allocating cpu memory on gpu

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the numactl package into the project's Docker build process. The primary goal is to enhance memory management on advanced NVIDIA architectures like GH200, GB200, and GB300, which feature Non-Uniform Memory Access (NUMA). By providing numactl, the system can more effectively control memory allocation, preventing CPU memory from being inadvertently used for GPU operations and thereby improving overall performance and resource utilization.

Highlights

  • numactl Installation: The numactl utility has been added to the Dockerfile, specifically to support systems with Non-Uniform Memory Access (NUMA) architectures like GH200, GB200, and GB300.
  • Improved Memory Management: This change aims to prevent the incorrect allocation of CPU memory on GPU-equipped systems, ensuring optimal memory utilization and performance on NUMA-enabled hardware.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the numactl package to the Docker image. This is a good addition, as numactl is a key utility for managing NUMA policy on systems like GH200/GB200, which is the motivation for this change. The implementation is straightforward. I have one minor suggestion to improve the maintainability of the Dockerfile.

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Oct 21, 2025

@ishandhanani btw feel free to add this change to your dockerfile and if it works in your next build I will merge it. I have not tested it personally since no fast arm box yet and thus rebuilding RL dep is too slow to run

@Fridge003 Fridge003 merged commit 0f0c430 into main Oct 24, 2025
23 checks passed
@Fridge003 Fridge003 deleted the fzyzcjy-patch-4 branch October 24, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments