Install numactl in Dockerfile for GH200/GB200/GB300#11853
Conversation
Summary of ChangesHello @fzyzcjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the numactl package to the Docker image. This is a good addition, as numactl is a key utility for managing NUMA policy on systems like GH200/GB200, which is the motivation for this change. The implementation is straightforward. I have one minor suggestion to improve the maintainability of the Dockerfile.
|
@ishandhanani btw feel free to add this change to your dockerfile and if it works in your next build I will merge it. I have not tested it personally since no fast arm box yet and thus rebuilding RL dep is too slow to run |
Motivation
it has NUMA memory by default, thus we may need a numactl to avoid allocating cpu memory on gpu
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist