[router] clean up workflow logs to debug for implementation details logs#11886
[router] clean up workflow logs to debug for implementation details logs#11886
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the logging strategy within the router's core components, specifically for job queue management and worker registration workflows. It adjusts the verbosity of certain log messages, moving them from the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request systematically changes many info! logs to debug! to reduce log verbosity, which is a good cleanup. I've found one case where changing a warn! to debug! might be too aggressive and could hide important information, and another case of a remaining inconsistency in log levels within the same logic block. Please see my detailed comments.
| } | ||
|
|
||
| warn!("Worker job queue worker {} stopped", worker_id); | ||
| debug!("Worker job queue worker {} stopped", worker_id); |
There was a problem hiding this comment.
Changing the log level for a worker stopping from warn! to debug! might be too aggressive. A worker stopping is a significant lifecycle event, and logging it at debug! level could hide important information during operation. If this is part of a graceful shutdown, info! would be a more appropriate level. This would ensure that graceful worker stops are still visible in standard logs without being as noisy as a warn!.
| debug!("Worker job queue worker {} stopped", worker_id); | |
| info!("Worker job queue worker {} stopped", worker_id); |
| debug!( | ||
| "Activated {} DP-aware workers {} (marked as healthy)", | ||
| workers.len(), | ||
| config.url |
There was a problem hiding this comment.
Checklist