Skip to content

[router] clean up workflow logs to debug for implementation details logs#11886

Merged
slin1237 merged 1 commit intomainfrom
rt-workflow-logs
Oct 21, 2025
Merged

[router] clean up workflow logs to debug for implementation details logs#11886
slin1237 merged 1 commit intomainfrom
rt-workflow-logs

Conversation

@slin1237
Copy link
Collaborator

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logging strategy within the router's core components, specifically for job queue management and worker registration workflows. It adjusts the verbosity of certain log messages, moving them from the info level to the debug level. This change aims to declutter standard operational logs, ensuring that only critical information is logged at the info level, while detailed implementation-specific events are reserved for debug logs, making it easier to diagnose issues without overwhelming log output during normal operation.

Highlights

  • Logging Verbosity Adjustment: Changed numerous info! level log messages to debug! level across the job queue and worker registration modules to reduce log noise during normal operation.
  • Job Queue Logging Refinement: Messages related to job queue initialization, job submission, worker lifecycle (start, processing, stop), worker registration workflow, and job completion are now logged at the debug level.
  • Worker Registration Workflow Logging: Detailed logs for worker connection mode detection, metadata discovery, DP info discovery, worker creation, URL normalization, worker registration, policy updates, and worker activation have been demoted to debug level.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request systematically changes many info! logs to debug! to reduce log verbosity, which is a good cleanup. I've found one case where changing a warn! to debug! might be too aggressive and could hide important information, and another case of a remaining inconsistency in log levels within the same logic block. Please see my detailed comments.

}

warn!("Worker job queue worker {} stopped", worker_id);
debug!("Worker job queue worker {} stopped", worker_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing the log level for a worker stopping from warn! to debug! might be too aggressive. A worker stopping is a significant lifecycle event, and logging it at debug! level could hide important information during operation. If this is part of a graceful shutdown, info! would be a more appropriate level. This would ensure that graceful worker stops are still visible in standard logs without being as noisy as a warn!.

Suggested change
debug!("Worker job queue worker {} stopped", worker_id);
info!("Worker job queue worker {} stopped", worker_id);

Comment on lines +731 to 734
debug!(
"Activated {} DP-aware workers {} (marked as healthy)",
workers.len(),
config.url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While changing this log to debug! is consistent with the PR's goal, it introduces an inconsistency. The else branch for non-DP-aware workers still logs worker activation at the info! level on line 744. For consistency, that log should also be changed to debug!.

@slin1237 slin1237 merged commit 1111030 into main Oct 21, 2025
31 of 33 checks passed
@slin1237 slin1237 deleted the rt-workflow-logs branch October 21, 2025 01:24
xjpang pushed a commit to xjpang/sglang that referenced this pull request Oct 22, 2025
@slin1237 slin1237 mentioned this pull request Oct 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments