[grpc] Support gRPC standard health check#11955
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
eb92c9f to
1ccca6d
Compare
slin1237
approved these changes
Oct 22, 2025
Collaborator
|
tested manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a HealthCheck servicer following gRPC's standard Health Checking Protocol,
grpc.health.v1.HealthThis enables native Kubernetes gRPC health probes without requiring custom scripts or tools.
Reference: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe
Health Check Services
The gRPC server exposes two health check services:
Overall Server Health (
service: "")SGLang Service Health (
service: "sglang.grpc.scheduler.SglangScheduler")Modifications
grpcio-health-checkingintopyproject.toml. This is required forHealthServicerexecwould requiregrpcurldependency, and it would be slower, so it has no advantage over the current approachSGLangHealthServicerto inherit from standardhealth_pb2_grpc.HealthServicer_run_scheduler_with_signal_handlingand_launch_scheduler_process_onlytogrpc/scheduler_handler.pyasgrpc_server.pyis getting too longKubernetes Configuration
Basic Example
Benchmarking and Profiling
Checklist