Accelerate deepseek fp4 b200 ci#11993
Conversation
Summary of ChangesHello @Qiaolin-Yu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request re-integrates the DeepSeek FP4 B200 CI test, which was previously disabled, into the continuous integration pipeline. The re-enabling is motivated by successful local testing, demonstrating a reasonable execution time. Alongside this, the PR introduces performance enhancements by caching Triton kernels and updates the draft extension logic to support a newer version. It also configures the KV cache to use Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request re-enables the CI test for deepseek-v3 fp4 on b200 GPUs. The changes include updating the test suite configuration and modifying the trtllm_mla_backend to support a new speculative decoding mode (DRAFT_EXTEND_V2). The logic seems correct and the changes are consistent with the goal of the PR. I have one suggestion to improve code clarity in the attention backend.
| if ( | ||
| forward_batch.forward_mode.is_extend() | ||
| and not forward_batch.forward_mode.is_target_verify() | ||
| and not forward_batch.forward_mode.is_draft_extend() | ||
| and not forward_batch.forward_mode.is_draft_extend(include_v2=True) | ||
| ): |
There was a problem hiding this comment.
The condition here is intended to check if the forward mode is EXTEND or MIXED. The current implementation is a bit complex and the change in this PR is redundant as it does not alter the logical outcome. For better readability and maintainability, I suggest simplifying this condition to directly check for these two modes.
mode = forward_batch.forward_mode
if mode == ForwardMode.EXTEND or mode == ForwardMode.MIXED:
Motivation
It's based on #11821 . Will rebase after that pr is merged.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist