Add gguf dependency for cpu/xpu#12041
Conversation
Summary of ChangesHello @ZailiWang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR adds the gguf dependency for CPU and XPU environments. While the changes themselves are correct, the underlying GGUF feature implementation appears to be CUDA-only. As seen in python/sglang/srt/layers/quantization/gguf.py, the necessary kernels are only imported for CUDA builds, which will lead to runtime errors on CPU and XPU. I've left critical comments on the dependency files suggesting to either add CPU/XPU support or remove these dependencies to prevent breaking these environments.
| "decord", | ||
| "einops", | ||
| "fastapi", | ||
| "gguf", |
There was a problem hiding this comment.
Adding the gguf dependency for CPU environments seems premature. The current GGUF implementation in python/sglang/srt/layers/quantization/gguf.py is CUDA-specific and will cause runtime NameErrors on CPU-only systems because the required kernels are not imported. This will break functionality for users trying to load GGUF models on CPU. It's recommended to either implement a CPU-compatible fallback for GGUF operations or remove this dependency until CPU support is complete.
| "decord", | ||
| "einops", | ||
| "fastapi", | ||
| "gguf", |
There was a problem hiding this comment.
Similar to the CPU build, adding the gguf dependency for XPU is problematic. The GGUF implementation in python/sglang/srt/layers/quantization/gguf.py only contains CUDA kernels and lacks any implementation for XPU. This will result in runtime errors when attempting to use GGUF models on XPU. Please consider adding XPU support or deferring this dependency to avoid shipping broken functionality.
ggufdependency is introduced in #11964