Conversation
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the system's logging capabilities by introducing a new configuration option to control the display of forward iteration counts in prefill and decode batch logs. It also undertakes a refactoring effort for existing logging-related environment variables, enhancing their organization and providing a clear deprecation path for older settings to ensure a more structured and user-friendly logging setup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an option to make the forward iteration count logging optional, controlled by the SGLANG_LOG_FORWARD_ITERS environment variable. This is a useful addition for controlling log verbosity. The changes also include refactoring of logging-related environment variables for better organization, such as renaming SGLANG_GC_LOG to SGLANG_LOG_GC.
My main feedback is to improve the backward compatibility for the renamed environment variable. Currently, it only issues a warning but doesn't use the value from the old variable, which could lead to silent misconfiguration for users. I've suggested a change to handle this gracefully.
related to #9366. Make it optional.