Skip to content

[log] Make forward iter count optional#12116

Merged
hnyls2002 merged 4 commits intomainfrom
lsyin/fix-log
Oct 26, 2025
Merged

[log] Make forward iter count optional#12116
hnyls2002 merged 4 commits intomainfrom
lsyin/fix-log

Conversation

@hnyls2002
Copy link
Collaborator

@hnyls2002 hnyls2002 commented Oct 25, 2025

related to #9366. Make it optional.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the system's logging capabilities by introducing a new configuration option to control the display of forward iteration counts in prefill and decode batch logs. It also undertakes a refactoring effort for existing logging-related environment variables, enhancing their organization and providing a clear deprecation path for older settings to ensure a more structured and user-friendly logging setup.

Highlights

  • Optional Forward Iteration Logging: Introduced a new environment variable, SGLANG_LOG_FORWARD_ITERS, which allows users to optionally include the iteration count in prefill and decode batch log messages, providing more granular control over log verbosity.
  • Logging Environment Variable Refactoring: Consolidated and organized logging-related environment variables under a new 'Logging Options' section in environ.py, improving clarity and maintainability of configuration settings.
  • Deprecation of SGLANG_GC_LOG: Renamed the SGLANG_GC_LOG environment variable to SGLANG_LOG_GC and added a deprecation warning to inform users about the change, ensuring a smooth transition for existing configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an option to make the forward iteration count logging optional, controlled by the SGLANG_LOG_FORWARD_ITERS environment variable. This is a useful addition for controlling log verbosity. The changes also include refactoring of logging-related environment variables for better organization, such as renaming SGLANG_GC_LOG to SGLANG_LOG_GC.

My main feedback is to improve the backward compatibility for the renamed environment variable. Currently, it only issues a warning but doesn't use the value from the old variable, which could lead to silent misconfiguration for users. I've suggested a change to handle this gracefully.

@hnyls2002 hnyls2002 merged commit bda3758 into main Oct 26, 2025
15 of 58 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/fix-log branch October 26, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments