Skip to content

Clean up server args & Add CI scripts#12124

Merged
merrymercy merged 1 commit intomainfrom
lianmin/fix-scheduler-loop
Oct 25, 2025
Merged

Clean up server args & Add CI scripts#12124
merrymercy merged 1 commit intomainfrom
lianmin/fix-scheduler-loop

Conversation

@merrymercy
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @merrymercy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the maintainability and clarity of server configurations by extensively refactoring and cleaning up server arguments. It also updates the project's documentation to reflect broader platform support and introduces new automation scripts for managing CI infrastructure.

Highlights

  • Server Argument Refactoring: Numerous server arguments within the ServerArgs dataclass and add_cli_args function in python/sglang/srt/server_args.py have been reorganized and reordered for improved clarity and logical grouping.
  • Deprecated Argument Removal: Several deprecated MoE-related command-line arguments have been removed from the add_cli_args function, streamlining the available options.
  • Documentation Updates: The installation guide (docs/get_started/install.md) has been updated to include new platform references such as TPU and NVIDIA DGX Spark.
  • CI Runner Scripts: A new suite of shell scripts has been introduced in scripts/ci_config_runner/ to automate the configuration and management of GitHub Actions self-hosted runners, including Docker and NVIDIA container toolkit setup.
  • Code Enhancements: Comments were added to launch_server.py for better server type identification, and lru_cache was applied to the is_npu function in utils/common.py for potential performance benefits.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@merrymercy merrymercy changed the title Clean up server args Clean up server args & Add CI scripts Oct 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a good cleanup of the server arguments, improving the organization and maintainability of the configuration code. The addition of CI runner scripts is also a valuable contribution. My feedback focuses on improving the robustness and security of these new scripts, with a critical suggestion to avoid hardcoding secret placeholders.

Comment on lines 35 to 38
curl -o actions-runner-linux-x64-2.321.0.tar.gz -L https://github.com/actions/runner/releases/download/v2.321.0/actions-runner-linux-x64-2.321.0.tar.gz

# Verify the checksum
echo "ba46ba7ce3a4d7236b16fbe44419fb453bc08f866b24f04d549ec89f1722a29e actions-runner-linux-x64-2.321.0.tar.gz" | shasum -a 256 -c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the runner version and its checksum can make future updates more difficult. Consider defining these as variables at the top of the script for easier maintenance.

@merrymercy merrymercy force-pushed the lianmin/fix-scheduler-loop branch from dc0cb48 to 03e6520 Compare October 25, 2025 17:42
@merrymercy merrymercy merged commit 4caca1b into main Oct 25, 2025
67 of 71 checks passed
@merrymercy merrymercy deleted the lianmin/fix-scheduler-loop branch October 25, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments