Skip to content

docs: update README#12139

Merged
zhyncs merged 1 commit intomainfrom
zhyncs/doc
Oct 26, 2025
Merged

docs: update README#12139
zhyncs merged 1 commit intomainfrom
zhyncs/doc

Conversation

@zhyncs
Copy link
Collaborator

@zhyncs zhyncs commented Oct 26, 2025

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining up-to-date project information by updating the README.md file. The changes primarily involve adding a new announcement to the news section and making minor formatting adjustments to existing news items, ensuring the project's public-facing documentation is current and consistent.

Highlights

  • News Section Update: A new entry has been added to the 'News' section for October 2025, highlighting SGLang's participation in AMD AI Dev Day and the PyTorch Conference.
  • Formatting Adjustment: The 'fire' emoji (🔥) has been removed from two existing news entries, specifically those for September 2025 (DeepSeek-V3.2 support) and August 2025 (AMD SF Meetup).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the README.md file to include new entries in the News section. The changes involve adding a new event, reformatting existing entries, and updating links to reflect recent activities and releases. No specific style guide was provided, so the review focuses on correctness and clarity.

| [**Slides**](https://github.com/sgl-project/sgl-learning-materials?tab=readme-ov-file#slides) |

## News
- [2025/10] 🔥 AMD AI Dev Day 2025 SGLang ([slide](https://github.com/sgl-project/sgl-learning-materials/blob/main/slides/sglang_amd_ai_devday_2025.pdf)), PyTorch Conference 2025 SGLang ([slide](https://github.com/sgl-project/sgl-learning-materials/blob/main/slides/sglang_pytorch_2025.pdf)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The slide link is using refs/heads/main which is not a permanent link. It's better to use a permanent link to avoid broken links in the future.

Suggestion: Use a commit SHA instead of refs/heads/main.

| [**Slides**](https://github.com/sgl-project/sgl-learning-materials?tab=readme-ov-file#slides) |

## News
- [2025/10] 🔥 AMD AI Dev Day 2025 SGLang ([slide](https://github.com/sgl-project/sgl-learning-materials/blob/main/slides/sglang_amd_ai_devday_2025.pdf)), PyTorch Conference 2025 SGLang ([slide](https://github.com/sgl-project/sgl-learning-materials/blob/main/slides/sglang_pytorch_2025.pdf)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The date format is inconsistent with the other entries. Consider standardizing the date format for better readability and consistency.

Suggestion: Use YYYY/MM format for all entries.

@zhyncs zhyncs merged commit fe52781 into main Oct 26, 2025
24 checks passed
@zhyncs zhyncs deleted the zhyncs/doc branch October 26, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments