Skip to content

[misc][grpc] Remove duplicate log#12168

Merged
slin1237 merged 1 commit intomainfrom
chang/remove-log
Oct 26, 2025
Merged

[misc][grpc] Remove duplicate log#12168
slin1237 merged 1 commit intomainfrom
chang/remove-log

Conversation

@CatherineSue
Copy link
Collaborator

@CatherineSue CatherineSue commented Oct 26, 2025

Motivation

Remove duplicate log in grpc_server.py as health_servicer.set_serving() already logs:

Health service status set to SERVING

Modifications

  • Remove logger.info("Health service marked as SERVING")

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the logging output of the gRPC server by eliminating a redundant log statement. The change ensures that the server's initialization process produces cleaner and more concise logs, avoiding duplicate messages when the health service status is updated.

Highlights

  • Duplicate Log Removal: Removed a redundant logger.info("Health service marked as SERVING") call in grpc_server.py to prevent duplicate log entries, as health_servicer.set_serving() already logs this status.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes a redundant log statement in grpc_server.py. The health_servicer.set_serving() method already logs the health service status, so this change effectively eliminates a duplicate log entry. This is a good simplification that improves code clarity. The change looks good to me.

@slin1237 slin1237 merged commit 94aad0d into main Oct 26, 2025
66 of 103 checks passed
@slin1237 slin1237 deleted the chang/remove-log branch October 26, 2025 21:07
@slin1237 slin1237 mentioned this pull request Oct 27, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments