Skip to content

[rust][ci] Add end-to-end tests for Oracle history backend#12233

Merged
slin1237 merged 4 commits intosgl-project:mainfrom
key4ng:oracle-db-ci
Oct 28, 2025
Merged

[rust][ci] Add end-to-end tests for Oracle history backend#12233
slin1237 merged 4 commits intosgl-project:mainfrom
key4ng:oracle-db-ci

Conversation

@key4ng
Copy link
Collaborator

@key4ng key4ng commented Oct 27, 2025

Motivation

  • Ensure the router works correctly when using Oracle as the history store and prevent regressions by covering it in CI.
  • Stand up an ephemeral Oracle XE in CI so tests don’t depend on external infra; install Oracle Instant Client so Python bindings can connect.

Modifications

CI workflow (.github/workflows/pr-test-rust.yml)

  • Install unzip and Oracle Instant Client 23.9; export LD_LIBRARY_PATH.
  • Run Oracle XE in Docker and expose ATP_USER=system, ATP_PASSWORD=oracle, ATP_DSN=localhost:1521/XEPDB1 for tests.
  • Add cleanup step to stop/remove the Oracle container after the job.

Tests (sgl-router/py_test/e2e_response_api/test_response_api.py)

  • Add TestOracleStore E2E suite targeting the Oracle history backend (router configured with history_backend=oracle).

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @key4ng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the continuous integration testing suite by incorporating a new test class dedicated to the Oracle history backend. This ensures the stability and correct operation of the router when configured to use Oracle for historical data storage, improving overall system reliability.

Highlights

  • New Test Suite: Introduced TestOracleStore to test_response_api.py for end-to-end testing of the Oracle database storage backend.
  • Oracle History Backend Testing: The new test suite specifically configures the openai-xai-router to use "oracle" as its history backend, ensuring its functionality is covered by CI.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pr-test-rust.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds end-to-end tests for the Oracle history backend. The change is a good step towards ensuring the reliability of this feature. My main feedback is to expand the test coverage by including existing test suites for state management and MCP, which are crucial for verifying the history backend's functionality. This will make the tests for the Oracle backend as comprehensive as the ones for the memory backend.

@key4ng key4ng changed the title Add ci test for oracle history backend[wip] [rust][ci] Add end-to-end tests for Oracle history backend Oct 28, 2025
@key4ng
Copy link
Collaborator Author

key4ng commented Oct 28, 2025

Hi @slin1237 this pr is ready for review

@slin1237 slin1237 merged commit 737b58d into sgl-project:main Oct 28, 2025
39 of 40 checks passed
@slin1237 slin1237 added router ci continue integration related labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci continue integration related router run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments