[rust][ci] Add end-to-end tests for Oracle history backend#12233
[rust][ci] Add end-to-end tests for Oracle history backend#12233slin1237 merged 4 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @key4ng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration testing suite by incorporating a new test class dedicated to the Oracle history backend. This ensures the stability and correct operation of the router when configured to use Oracle for historical data storage, improving overall system reliability. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds end-to-end tests for the Oracle history backend. The change is a good step towards ensuring the reliability of this feature. My main feedback is to expand the test coverage by including existing test suites for state management and MCP, which are crucial for verifying the history backend's functionality. This will make the tests for the Oracle backend as comprehensive as the ones for the memory backend.
|
Hi @slin1237 this pr is ready for review |
Motivation
Modifications
CI workflow (.github/workflows/pr-test-rust.yml)
Tests (sgl-router/py_test/e2e_response_api/test_response_api.py)
Accuracy Tests
Benchmarking and Profiling
Checklist