[router] harmony responses api streaming support#12395
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Harmony Responses API by adding comprehensive streaming support. This allows clients to receive real-time updates on the progress of a response, including intermediate tool calls, analysis, and partial text generation, via Server-Sent Events (SSE). The changes involve a new streaming endpoint, modifications to the core processing pipeline to handle streaming requests, and a robust event emission system to provide a dynamic and interactive user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces streaming support for the Harmony responses API, a significant feature enhancement. The implementation involves substantial changes, including a new streaming service function, modifications to the request pipeline to accommodate streaming, and a new streaming processor. The overall approach is sound, but I have identified two areas for improvement. One is a potential panic in error handling that could crash the streaming task, and the other is significant code duplication in the new streaming processor, which impacts maintainability. Addressing these points will improve the robustness and quality of the new streaming functionality.

Overview
This PR implements complete streaming support for Harmony-enabled models in the Responses API, including incremental token parsing, 14 SSE event types, channel-based response processing, and MCP tool loop orchestration.
Scope:
Data Flow
Checklist