[router] Fix safety_identifier missing

[key4ng]

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

[gemini-code-assist]

Summary of Changes

Hello @key4ng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a continuous integration (CI) failure by ensuring that the safety_identifier field is always explicitly initialized to None within the ResponseUsage struct. This change prevents potential issues that could arise from an uninitialized or missing field during the build and test processes, thereby allowing the CI pipeline to pass successfully.

Highlights

• CI Fix: Resolved a CI blocking issue by explicitly initializing the safety_identifier field to None in the ResponseUsage struct within the HarmonyStreamingProcessor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the safety_identifier field to the ResponsesResponse struct initialization in sgl-router/src/routers/grpc/harmony/streaming.rs, which appears to fix a compilation issue. The change is correct and necessary, setting the field to None which is appropriate for the placeholder struct in this context.

While reviewing, I noticed a potential related issue in sgl-router/src/routers/grpc/harmony/processor.rs, which is not part of this PR's changes. In the process_responses_iteration function, safety_identifier is assigned the value of responses_request.user. This seems semantically incorrect, as user is a user identifier, not a safety identifier for content moderation. You might want to investigate this and address it in a separate change to ensure the safety_identifier feature is implemented consistently.