use fast stream instead of torch.cuda.current_stream in llama 4 shared experts overlap#12811
Conversation
Summary of ChangesHello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the CUDA stream management within the Llama 4 model's shared experts overlap implementation. By switching to a more optimized method for retrieving the current device stream, the change aims to enhance the efficiency of GPU operations and synchronization. Although the general performance metrics show minor differences, the improvement in tail latency for the first token suggests a positive impact on user experience for certain workloads. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a performance optimization by replacing torch.cuda.current_stream() with a faster, cached version get_current_device_stream_fast() within the Llama 4 shared experts overlap implementation. This change is consistent with similar optimizations made elsewhere in the codebase and aims to reduce the overhead of CUDA API calls. The implementation appears correct and the change is well-contained. My review did not identify any issues.
Don't use
torch.cuda.current_stream, useget_current_device_stream_fast(), just like #12524Generally, it doesn't make such a great difference.