Skip to content

Conversation

@key4ng
Copy link
Collaborator

@key4ng key4ng commented Nov 7, 2025

Motivation

The MCP integration tests were using the external DeepWiki MCP server (https://mcp.deepwiki.com/mcp), which frequently hit rate limits during CI runs. This caused tests to be temporarily skipped, reducing test coverage for the MCP feature.

Modifications

Modifications

  1. CI Infrastructure (.github/workflows/pr-test-rust.yml:262-271):
    - Added Dockerized Brave MCP server (shoofio/brave-search-mcp-sse:1.0.10) running on port 8001
    - Added health check and cleanup steps for container lifecycle management
  2. Test Implementation (sgl-router/py_test/e2e_response_api/):
    - Replaced DeepWiki server URL with local Brave server (http://localhost:8001/sse)
    - Re-enabled previously skipped tests by removing @unittest.skip decorators
    - Refactored MCP test constants into shared class attributes for better maintainability
    - Updated test prompts to simpler queries about "sglang router news" with explicit result limits backends

Accuracy Tests

Benchmarking and Profiling

Checklist

@github-actions github-actions bot added router and removed run-ci labels Nov 7, 2025
@key4ng key4ng added the run-ci label Nov 7, 2025
@key4ng key4ng changed the title update mcp ci [router] Switch MCP tests from DeepWiki to self-hosted Brave search server Nov 7, 2025
@key4ng key4ng marked this pull request as ready for review November 7, 2025 23:01
@slin1237 slin1237 merged commit d3d7f96 into sgl-project:main Nov 8, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants