add back flashinfer jit cache to dev docker#12851
Conversation
Summary of ChangesHello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reintroduces the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds back the installation of flashinfer-jit-cache to the Dockerfile, controlled by a new build argument INSTALL_FLASHINFER_JIT_CACHE. This is useful for development environments. My review identifies a critical syntax error in the shell command that will break the build, and also suggests an improvement for robustness. Please see the detailed comment.
| fi \ | ||
| && python3 -m pip install -e "python[${BUILD_TYPE}]" --extra-index-url https://download.pytorch.org/whl/cu${CUINDEX} \ | ||
| && if [ "$INSTALL_FLASHINFER_JIT_CACHE" = "1" ]; then \ | ||
| python3 -m pip install flashinfer-jit-cache==0.5.0 --index-url https://flashinfer.ai/whl/cu${CUINDEX} ; \ |
There was a problem hiding this comment.
This line has two issues:
-
Syntax Error: The trailing backslash
\is incorrect. It escapes the newline, which will cause theifstatement to be malformed and break the build. It should be removed. -
Robustness: Using
--index-urlreplaces the default package index. Ifflashinfer-jit-cachehas dependencies that are not on theflashinfer.aiindex, this step will fail. Using--extra-index-urlis safer as it adds the new index without removing the default one.
The suggested code below fixes both issues.
python3 -m pip install flashinfer-jit-cache==0.5.0 --extra-index-url https://flashinfer.ai/whl/cu${CUINDEX} ;
|
Ready to merge once this https://github.com/sgl-project/sglang/actions/runs/19182192233 is green |
|
This failed the nightly dev image build. Can you take a look? We also need a more automated way to maintain the version in two places. https://github.com/sgl-project/sglang/actions/runs/19397619609/job/55499873230#step:7:4792 |

for ease of development & since the dev docker does not have a slim requirement