[Auto Sync] Update activation.py, logits_processor.py, rota... (20251107)#12853
[Auto Sync] Update activation.py, logits_processor.py, rota... (20251107)#12853
Conversation
…107) Co-authored-by: Stefan He <hebiaobuaa@gmail.com>
Summary of ChangesHello @merrymercy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated synchronization of recent changes, primarily focusing on making the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is an automated sync that generalizes the handling of the rl_on_policy_target server argument. The changes replace specific checks for this argument being equal to 'fsdp' with a more general check for it not being None. This makes the feature applicable to any on-policy reinforcement learning target, not just FSDP. Additionally, server_args.py is updated to make the list of choices for this argument extensible. The changes are consistent across all modified files and improve the code's maintainability and extensibility. The implementation is correct and I have no further suggestions.
Sync changes from commit
e0a34788.Files Changed:
Author: Stefan He hebiaobuaa@gmail.com
This is an automated PR created by scripts/copy_from_oss.py.