[chore] update torch version to 2.9#12969
Conversation
Summary of ChangesHello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency upgrade, specifically updating the PyTorch framework to version 2.9.0 across the project. This involves modifying the primary Python dependency configuration and adjusting the kernel build script to reflect the new PyTorch version for various CUDA environments, streamlining the development and deployment process with the latest stable release. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Torch dependency to version 2.9.0. The changes in python/pyproject.toml and sgl-kernel/build.sh are consistent with this goal. I've provided one suggestion in sgl-kernel/build.sh to refactor the logic for setting the TORCH_INSTALL variable, which will improve code clarity and make future updates easier. Additionally, while not part of this PR's changes, you might want to review other dependency files like sgl-kernel/pyproject.toml and sgl-kernel/pyproject_rocm.toml to ensure their Torch version constraints are also updated for consistency across the project.
|
@FlamingoPg Seems triton is failing with this error https://github.com/sgl-project/sglang/actions/runs/19317390340/job/55254572458?pr=12969 We have met similar situations before. It's caused by https://github.com/triton-lang/triton/pull/8536/files, and we solved it by pinning the version of Triton to the commit before this culprit. |
I see, looks we need to update triton_kernels in CMakeLists.txt https://github.com/triton-lang/triton/blob/3543fe1d52dd84fd4e5b792f916cafe2824e46ea/python/triton_kernels/triton_kernels/numerics_details/flexpoint.py#L54 |
|
Updates related to Torch 2.9
|
|
https://github.com/sgl-project/sglang/pull/12969/checks?check_run_id=56374158981 |
Motivation
As titled, update torch version to 2.9
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist