Skip to content

Revert "fix: display served_model_name in /v1/models"#13093

Merged
slin1237 merged 1 commit intomainfrom
revert-13063-router_fix
Nov 11, 2025
Merged

Revert "fix: display served_model_name in /v1/models"#13093
slin1237 merged 1 commit intomainfrom
revert-13063-router_fix

Conversation

@CatherineSue
Copy link
Collaborator

@CatherineSue CatherineSue commented Nov 11, 2025

Reverts #13063

The PR did not pass CI lint check.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of a previous change (#13063) that attempted to introduce and display a served_model_name. The decision to revert was made because the original implementation failed CI lint checks and was deemed an incorrect approach. The PR effectively rolls back all associated code, ensuring the codebase returns to its state before the problematic change was introduced.

Highlights

  • Revert Previous Change: This pull request fully reverts the changes introduced in fix: display served_model_name in /v1/models #13063, which aimed to display the served_model_name in the /v1/models endpoint.
  • Reason for Revert: The original pull request failed CI lint checks and was identified as an incorrect implementation, necessitating this rollback.
  • Code Removal: All code related to served_model_name, including its field in the ServerInfo struct and its usage in model identification and metadata discovery logic, has been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that introduced the served_model_name field. The revert removes the field from the ServerInfo struct and its handling in the HTTP discovery path. However, the revert appears to be incomplete. The CreateWorkerStep step still attempts to derive a model_id from served_model_name, which will no longer be present in the labels for HTTP workers. This could lead to inconsistent behavior between HTTP and gRPC workers. I've also provided a couple of suggestions to improve the code quality of the reverted code.

@slin1237 slin1237 merged commit 2ca25a8 into main Nov 11, 2025
46 of 47 checks passed
@slin1237 slin1237 deleted the revert-13063-router_fix branch November 11, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments