Skip to content

[router] Fix Flaky test_circuit_breaker_opens_and_recovers #13164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CatherineSue merged 3 commits into from
Nov 12, 2025
Merged

[router] Fix Flaky test_circuit_breaker_opens_and_recovers #13164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be517b2
Fix test_circuit_breaker_opens_and_recovers
Nov 12, 2025
e60990a
Reformat
Nov 12, 2025
e3e791f
Merge branch 'main' into xinyue/fix-flaky-circuit-breaker-test
Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion sgl-router/py_test/integration_mock/test_circuit_breaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,21 @@ def post_once():
timeout=3,
)

saw_503 = False
# should see 500 when worker actually starts, before that should see 503
saw_500 = False
for _ in range(8):
r = post_once()
if r.status_code == 500:
# Worker starts, continue to circuit breaker test
saw_500 = True
break
assert (
r.status_code == 503
), "Should only see 503 when waiting for worker to start"
assert saw_500, "Worker didn't start after 8 requests"

saw_503 = False
for _ in range(4):
r = post_once()
if r.status_code == 503:
saw_503 = True
Expand Down
Loading