[CI][VLM]: Add UT for multimodal cache eviction#13370
[CI][VLM]: Add UT for multimodal cache eviction#13370ZhengWG wants to merge 15 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @ZhengWG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness of the VLM multimodal cache by restoring and improving its unit testing. It ensures that the cache's eviction mechanism functions correctly under memory pressure, which is critical for performance and stability. The changes include re-enabling a specific test scenario and adding detailed logging to verify the eviction process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@mickqian Plz take a loot at it. |
There was a problem hiding this comment.
Code Review
This pull request effectively restores and enhances testing for the multimodal cache eviction logic. By adding a specific unit test with a small cache size and introducing debug logs for eviction events, it significantly improves the verifiability and observability of this critical feature. The implementation is solid. I've provided a couple of minor suggestions to enhance code style and readability.
|
@JustinTong0323 @yuan-luo Can you help review it~ |
|
/tag-and-rerun-ci |
|
/rerun-failed-ci |
|
@yuan-luo |
|
/rerun-failed-ci |
1 similar comment
|
/rerun-failed-ci |

Motivation
Restores the test_vlm_mmmu_benchmark_with_small_cache test to verify VLM MMMU cache eviction logic under memory constraints, which was affected by PR f5b3ccd.
related with #12984
Modifications
Readded test scenario with 5MB embedding cache and log-based eviction detection
Added debug logging for "Cache eviction" events in MultiModalStaticCache.set
Accuracy Tests
Test Result:
Parameter explanation:
Benchmarking and Profiling
Checklist