-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[router] bindings for go #13384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[router] bindings for go #13384
Conversation
Summary of ChangesHello @whybeyoung, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a brand new Go SDK for the SGLang gRPC API. The primary goal is to provide Go developers with a familiar and easy-to-use interface, mirroring the popular OpenAI SDK. It enables seamless interaction with SGLang's capabilities, including real-time streaming and advanced chat functionalities, by integrating a high-performance Rust FFI layer. The SDK is thoroughly tested and well-documented to facilitate adoption and development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
71dad33 to
2650642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Go bindings for the SGLang gRPC API, which is a significant and well-structured contribution. The new bindings include the Go client library, Rust FFI layer, build files, examples, and comprehensive documentation. My review focuses on improving the developer experience, enhancing the robustness of the Go client, fixing issues in tests, and cleaning up the underlying Rust FFI code. Key areas for improvement include making the build process more conventional, correctly handling context cancellation in the Go client, and improving the accuracy of tests and documentation.
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
Signed-off-by: ybyang <[email protected]>
A high-level Go SDK for interacting with SGLang gRPC API, designed with an OpenAI-style API for familiarity and ease of use.
CC @slin1237