Skip to content

Conversation

@ch-wan
Copy link
Collaborator

@ch-wan ch-wan commented Nov 28, 2025

Removed assertions related to DeepGemm MoE runner backend.

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Removed assertions related to DeepGemm MoE runner backend.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ch-wan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration validation issue by removing an incorrect assertion within the server argument parsing logic. The removed assertion was erroneously restricting the usage of the deep_gemm MoE runner backend, which could prevent valid system configurations. By eliminating this faulty check, the change enhances the flexibility and correctness of how MoE backends are configured.

Highlights

  • Assertion Removal: The pull request removes an assertion related to the "deep_gemm" MoE runner backend in server_args.py. This assertion incorrectly enforced ep_size > 1 and moe_a2a_backend == "deepep" for DeepGemm, which was found to be an incorrect constraint.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an incorrect assertion related to the deep_gemm MoE runner backend. The assertion required ep_size > 1 and moe_a2a_backend == "deepep", which was overly restrictive as the deep_gemm runner is also designed to work with moe_a2a_backend="none" (implying ep_size=1). The removal of this assertion is correct and allows for more flexible configuration of the MoE runner. The change is simple and looks good.

@Kangyan-Zhou
Copy link
Collaborator

/tag-and-rerun-ci

@ch-wan ch-wan merged commit 0fe74af into main Nov 29, 2025
84 of 137 checks passed
@ch-wan ch-wan deleted the ch-wan-patch-1 branch November 29, 2025 04:25
harvenstar pushed a commit to harvenstar/sglang that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants