Add 'NPU' to the runtime exception message in get_device#14225
Add 'NPU' to the runtime exception message in get_device#14225ping1jing2 merged 2 commits intosgl-project:mainfrom
get_device#14225Conversation
Summary of ChangesHello @rauletorresc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by improving the specificity of error messages within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds 'NPU' to the runtime exception message in the get_device function, improving clarity when an NPU accelerator is not available. The change is straightforward and directly addresses the motivation outlined in the pull request description.
|
/tag-and-rerun-ci |
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
…ct#14225) Co-authored-by: ronnie_zheng <zl19940307@163.com>
Motivation
Although
get_devicealso checks for support for NPU devices, if no NPU is available the runtime exception messages only reports CUDA, XPU and HPU devices.Modifications
Add NPU to the list of unavailable devices in the runtime exception message.
Accuracy Tests
Not applicable.
Benchmarking and Profiling
Not applicable.
Checklist