[Ascend] fix AscendAttnMaskBuilder bug to support float16 models#14271
Merged
iforgetmyname merged 3 commits intosgl-project:mainfrom Dec 3, 2025
Merged
[Ascend] fix AscendAttnMaskBuilder bug to support float16 models#14271iforgetmyname merged 3 commits intosgl-project:mainfrom
iforgetmyname merged 3 commits intosgl-project:mainfrom
Conversation
MichelleWu351
requested review from
iforgetmyname and
ping1jing2
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
MichelleWu351
changed the title
MichelleWu351
changed the title
Collaborator
|
/tag-and-rerun-ci |
ping1jing2
approved these changes
Dec 2, 2025
iforgetmyname
approved these changes
Dec 2, 2025
tom-jerr
pushed a commit
to tom-jerr/sglang
that referenced
this pull request
Dec 4, 2025
yingluosanqian
pushed a commit
to yingluosanqian/sglang
that referenced
this pull request
Dec 4, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
yuchengz816-bot
pushed a commit
to yuchengz816-bot/sglang
that referenced
this pull request
Dec 8, 2025
Kevin-XiongC
pushed a commit
to novitalabs/sglang
that referenced
this pull request
Dec 9, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
AscendAttnMaskBuilderclass implements a system for generating, caching, and updating attention masks. However, there is a bug when using this class with Ascend devices and a model configured with thefloat16data type. This pull request can fix the bug.Modifications
Modify the
generate_attn_maskfuction in theAscendAttnMaskBuilderclass.Accuracy Tests
Benchmarking and Profiling
Checklist