[bugfix] NpuFuseEPMoE miss initialization parameters#14295
[bugfix] NpuFuseEPMoE miss initialization parameters#14295iforgetmyname merged 2 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @chenxu140, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/tag-and-rerun-ci |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug in the NpuFuseEPMoE class where it was missing initialization parameters. By adding **kwargs to the __init__ method and passing them to the superclass constructor, the change ensures that any additional parameters required by the parent classes (DeepEPMoE and FusedMoE) are properly forwarded. This is a good fix that improves the robustness and flexibility of the class. The changes are correct and well-implemented.
Motivation
bugfix:
NpuFuseEPMoE miss initialization parameters.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist