Skip to content

[bugfix] NpuFuseEPMoE miss initialization parameters#14295

Merged
iforgetmyname merged 2 commits intosgl-project:mainfrom
ping1jing2:bugfix
Dec 3, 2025
Merged

[bugfix] NpuFuseEPMoE miss initialization parameters#14295
iforgetmyname merged 2 commits intosgl-project:mainfrom
ping1jing2:bugfix

Conversation

@chenxu140
Copy link
Contributor

@chenxu140 chenxu140 commented Dec 2, 2025

Motivation

bugfix:
NpuFuseEPMoE miss initialization parameters.

Modifications

Accuracy Tests

image

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenxu140, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the NpuFuseEPMoE class by ensuring that all initialization parameters are correctly passed to its parent class. The change involves updating the constructor signature and its call to the superclass, which resolves the problem of missing initialization parameters and improves the robustness of the component.

Highlights

  • Bug Fix: Resolves an issue where the NpuFuseEPMoE class was not correctly handling all initialization parameters, leading to potential misconfigurations or errors.
  • Parameter Handling: Modifies the __init__ method of NpuFuseEPMoE to accept and pass arbitrary keyword arguments (**kwargs) to its superclass, ensuring proper propagation of all necessary initialization parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@iforgetmyname
Copy link
Collaborator

/tag-and-rerun-ci

@github-actions github-actions bot added the run-ci label Dec 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a bug in the NpuFuseEPMoE class where it was missing initialization parameters. By adding **kwargs to the __init__ method and passing them to the superclass constructor, the change ensures that any additional parameters required by the parent classes (DeepEPMoE and FusedMoE) are properly forwarded. This is a good fix that improves the robustness and flexibility of the class. The changes are correct and well-implemented.

@ping1jing2 ping1jing2 self-assigned this Dec 2, 2025
@iforgetmyname iforgetmyname merged commit 16d8de2 into sgl-project:main Dec 3, 2025
194 of 216 checks passed
tom-jerr pushed a commit to tom-jerr/sglang that referenced this pull request Dec 4, 2025
yingluosanqian pushed a commit to yingluosanqian/sglang that referenced this pull request Dec 4, 2025
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
yuchengz816-bot pushed a commit to yuchengz816-bot/sglang that referenced this pull request Dec 8, 2025
Kevin-XiongC pushed a commit to novitalabs/sglang that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments