Skip to content

Feature/add vae path to cli doc#14004#14355

Merged
mickqian merged 11 commits intosgl-project:mainfrom
baonudesifeizhai:feature/add-vae-path-to-cli-doc
Dec 3, 2025
Merged

Feature/add vae path to cli doc#14004#14355
mickqian merged 11 commits intosgl-project:mainfrom
baonudesifeizhai:feature/add-vae-path-to-cli-doc

Conversation

@baonudesifeizhai
Copy link
Contributor

Motivation

Add documentation for the --vae-path CLI argument as requested in #14004 review feedback.

#14004

Modifications

-Added --vae-path parameter description to Server Arguments section in cli.md

  • Updated JSON and YAML configuration examples to include vae_path field

Accuracy Tests

Benchmarking and Profiling

Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation diffusion SGLang Diffusion labels Dec 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @baonudesifeizhai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the user documentation for the SGLang-diffusion CLI. It addresses feedback from a previous review by adding details for the --vae-path argument and updating configuration examples. The changes aim to make it clearer for users how to specify custom VAE models, thereby enhancing the usability and completeness of the CLI documentation.

Highlights

  • CLI Documentation Update: Added comprehensive documentation for the --vae-path command-line argument within the SGLang-diffusion CLI, clarifying its purpose and usage.
  • Configuration Examples Enhanced: Updated both JSON and YAML configuration examples to explicitly include the vae_path field, demonstrating how to specify a custom VAE model in configuration files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the --vae-path command-line argument, including updating the CLI documentation and configuration examples. The changes are clear and address the intended goal. I have one suggestion to improve the documentation by including the default behavior of the --vae-path argument, which would make it more complete for users.

@mickqian mickqian force-pushed the feature/add-vae-path-to-cli-doc branch from c5e6735 to 5b90ade Compare December 3, 2025 15:11
@mickqian mickqian merged commit aca0d01 into sgl-project:main Dec 3, 2025
42 of 45 checks passed
tom-jerr pushed a commit to tom-jerr/sglang that referenced this pull request Dec 4, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
yingluosanqian pushed a commit to yingluosanqian/sglang that referenced this pull request Dec 4, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
yuchengz816-bot pushed a commit to yuchengz816-bot/sglang that referenced this pull request Dec 8, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
Kevin-XiongC pushed a commit to novitalabs/sglang that referenced this pull request Dec 9, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 12, 2025
Co-authored-by: BBuf <1182563586@qq.com>
Co-authored-by: Mick <mickjagger19@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments