Conversation
hnyls2002
commented
Dec 3, 2025
- Also assert eval result when not in CI
- Enable multithread loading to speed up.
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the model ecosystem by integrating MistralLarge3 and Pixtral models, enhancing the framework's capability to handle diverse architectures. It also brings substantial improvements to FP8 quantization for MoE layers, introducing block-level granularity for better performance and precision. Additionally, it includes refinements to CI testing for DeepseekV3 and a more robust model information retrieval mechanism in the router. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements, primarily adding support for new models like MistralLarge3 and Pixtral, and implementing block quantization for FP8. The changes are well-structured and include necessary refactoring to accommodate these new features. My review focuses on ensuring the correctness and maintainability of these additions. I've identified a critical missing import that would cause a runtime error, a redundant variable assignment, an unconventional import path, and an issue with boolean representation in a JSON string in the test files. Overall, the changes are substantial and move the project forward, but the identified issues should be addressed.
python/sglang/srt/layers/quantization/compressed_tensors/compressed_tensors.py
Outdated
Show resolved
Hide resolved
30c9e79 to
5f467ac
Compare