[model-gateway] add llava model image processor and tests#14371
[model-gateway] add llava model image processor and tests#14371
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates robust support for LLaVA model image preprocessing within the model-gateway. It provides dedicated processors for different LLaVA versions and modes, integrates them into a central registry for easy access, and establishes a rigorous testing framework using golden outputs from HuggingFace to guarantee accurate and consistent image transformations. This enhancement significantly expands the multimodal capabilities of the gateway. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds image processors for LLaVA models, including a Python script for generating golden test files and corresponding integration tests. The implementation is well-structured and the testing approach is robust. My review focuses on a few key areas for improvement. I've found a high-severity issue in the LlavaNextProcessor batch processing logic that could lead to performance degradation and stack overflows, and a correctness bug in an image centering function. Additionally, I've suggested a refactoring in the new test file to reduce code duplication and improve maintainability. After addressing these points, this will be an excellent addition.
Checklist