[model-gateway][doc] Add STDIO Explicitly to Example in README#14393
[model-gateway][doc] Add STDIO Explicitly to Example in README#14393slin1237 merged 2 commits intosgl-project:mainfrom
Conversation
Summary of ChangesHello @xuwenyihust, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an inconsistency in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a documentation issue in README.md regarding the MCP configuration for stdio transports. The documentation previously suggested that the protocol field was optional, while the implementation requires it to be explicitly declared. The changes update the example and the field description to reflect the correct usage, which is a valuable clarification. I have one minor suggestion to improve the readability of the updated documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This MCP service can start normally, but how do I use it? and test_mcp.py model server error log: gateway error log: I want to know how to test Filesystem MCP? |


Motivation
There's a small discrepancy between the README and the current implementation,
The README.md suggests that for an
stdiotransport, theprotocolfield is optional and can be inferred from the presence of a commandwith example
But i realized that protocol field could be mandatory during McpTransport deserialization, and omitting protocol: "stdio" will cause an error
Modifications
Update README to explictly set
protocolasstdio.Accuracy Tests
Can successfully connect with
protocol: "stdio"added.Checklist