chore: bump sgl-kernel version to 0.3.18.post3 #14427
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,7 +9,7 @@ build-backend = "setuptools.build_meta" | |||||
|
|
||||||
| [project] | ||||||
| name = "sgl-kernel" | ||||||
| version = "0.3.18.post3" | ||||||
|
Contributor
There was a problem hiding this comment. To improve maintainability and establish a single source of truth for the version number, consider using dynamic versioning. This would allow the version to be read directly from Since this file uses [tool.setuptools]
package-dir = {"" = "python"}
[tool.setuptools.dynamic]
version = { attr = "sgl_kernel.version.__version__" }This change will make
Suggested change
|
||||||
| description = "Kernel Library for SGLang" | ||||||
| readme = "README.md" | ||||||
| requires-python = ">=3.10" | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.3.18.post3" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and establish a single source of truth for the version number, consider using dynamic versioning. This would allow the version to be read directly from
python/sgl_kernel/version.py, eliminating the need for manual updates in this file.You can implement this by replacing this line with
dynamic = ["version"]and adding the following to your[tool.scikit-build]section:scikit-build-coredefaults to a regex provider that will correctly parse the__version__variable. This change will makepython/sgl_kernel/version.pythe single source of truth, simplifying the version bumping process.