-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Revert "tiny remove deprecated endpoint call" #14533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1480,7 +1480,7 @@ def _execute_server_warmup( | |
| for _ in range(120): | ||
| time.sleep(1) | ||
| try: | ||
| res = requests.get(url + "/model_info", timeout=5, headers=headers) | ||
| res = requests.get(url + "/get_model_info", timeout=5, headers=headers) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change reverts the server warmup logic to call the deprecated |
||
| assert res.status_code == 200, f"{res=}, {res.text=}" | ||
| success = True | ||
| break | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note is updated to refer to
/get_server_info, but the server implementation marks this endpoint as deprecated. This could be confusing for users reading the documentation. To improve clarity, I suggest rephrasing the note to clarify the relationship between the new and old endpoints.