[Perf] Fused qk_norm_rope for GLM4.6#14952
Closed
Kevin-XiongC wants to merge 10 commits intosgl-project:mainfrom
Closed
[Perf] Fused qk_norm_rope for GLM4.6#14952Kevin-XiongC wants to merge 10 commits intosgl-project:mainfrom
Kevin-XiongC wants to merge 10 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
@Kevin-XiongC Please split the sgl-kernel change into an independent PR such like #14036. |
6 tasks
Contributor
Author
Collaborator
6 tasks
Alcanderian
reviewed
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Inspired by #13998
Modifications
Glm4MoeAttention:rotary_dimparameter to support partial rotary embedding:rotary_dim < head_dim(e.g.,partial_rotary_factor=0.5)rotary_dimdimensionsUse
--enable-fused-qk-norm-ropeto turn on.Accuracy Tests
KERNEL UT
E2E
Benchmarking and Profiling
On 8xH20
BEFORE
AFTER
Checklist