Skip to content

[model-gateway] Improve logging in data_connector module#15495

Merged
slin1237 merged 1 commit intomainfrom
db-logs
Dec 19, 2025
Merged

[model-gateway] Improve logging in data_connector module#15495
slin1237 merged 1 commit intomainfrom
db-logs

Conversation

@slin1237
Copy link
Collaborator

  • Remove outdated bug reference comment in factory.rs
  • Change memory.rs info logs to debug level for store operations
  • Replace println with tracing::debug in postgres.rs

Checklist

- Remove outdated bug reference comment in factory.rs
- Change memory.rs info logs to debug level for store operations
- Replace println with tracing::debug in postgres.rs
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the logging mechanisms within the "data_connector" module. The primary goal is to optimize log verbosity by demoting certain routine operations from "info" to "debug" level and standardizing logging calls by replacing "println!" with the "tracing" crate. Additionally, an obsolete comment referencing a fixed bug has been removed, contributing to overall code cleanliness. These changes aim to make logs more actionable and less noisy without impacting the application's functional behavior.

Highlights

  • Logging Level Adjustment: Adjusted logging levels from "info" to "debug" for memory store operations in "memory.rs" to reduce log verbosity for routine operations.
  • Logging Mechanism Update: Replaced direct "println!" calls with "tracing::debug!" in "postgres.rs" for consistent and structured logging.
  • Code Cleanup: Removed an outdated bug reference comment in "factory.rs" to improve code clarity and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves logging consistency in the data_connector module by removing an outdated comment, changing some log levels from info to debug, and replacing a println! with a tracing::debug! call. The changes are generally good and improve code quality. However, I've identified a critical issue in postgres.rs where an .unwrap() call can cause the service to panic. I've left a specific comment with a suggestion to fix it.

@slin1237 slin1237 merged commit b5eb021 into main Dec 19, 2025
64 of 68 checks passed
@slin1237 slin1237 deleted the db-logs branch December 19, 2025 20:57
Prozac614 pushed a commit to Prozac614/sglang that referenced this pull request Dec 23, 2025
jiaming1130 pushed a commit to zhuyijie88/sglang that referenced this pull request Dec 25, 2025
GuoYechang pushed a commit to GuoYechang/sglang that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments