[VLM] Tiny: Unify VLM environment variables

[yuan-luo]

Motivation

Super tiny refactor to unify vlm environ variables.

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.
• Work with maintainers to merge your PR. See the PR Merge Process

[gemini-code-assist]

Summary of Changes

Hello @yuan-luo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a minor refactoring to streamline the handling of Vision-Language Model (VLM) environment variables. The primary goal is to consolidate environment variable declarations and access patterns, ensuring a more consistent and maintainable codebase. This change introduces a new VLM-specific environment variable into the central envs class and updates its usage across relevant modules.

Highlights

• Unified Environment Variable Management: The pull request centralizes the management of Vision-Language Model (VLM) related environment variables by integrating them into the envs class.
• New Environment Variable: A new environment variable, SGLANG_VIT_ENABLE_CUDA_GRAPH, has been introduced into the envs class for consistent access.
• Refactored Environment Variable Access: Existing checks for SGLANG_VIT_ENABLE_CUDA_GRAPH across various VLM-related modules have been updated to use the unified envs.SGLANG_VIT_ENABLE_CUDA_GRAPH.get() method, replacing direct calls to get_bool_env_var.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a nice refactoring that unifies the access to VLM-related environment variables by centralizing them in sglang.srt.environ.py. The changes are clean and improve code consistency. I have one minor suggestion to add a comment for the new environment variable to improve maintainability.

[yhyang201]

/tag-and-rerun-ci

[yuan-luo]

/tag-and-rerun-ci

[yuan-luo]

/tag-and-rerun-ci

[yuan-luo]

/tag-and-rerun-ci