Optimize Rust CI builds with proper sccache configuration#15581
Optimize Rust CI builds with proper sccache configuration#15581
Conversation
- Add sccache to pr-test-pd-router.yml (was missing entirely) - Add RUSTC_WRAPPER and SCCACHE_GHA_ENABLED env vars - Replace old actions/cache with Swatinem/rust-cache + sccache - Standardize shared-key: "rust-cache" across all jobs for cache reuse - Add save-if: true to persist cache even on failure - Add rust-cache to maturin-build-test job - Add instructions for optional sccache setup - Note that project defaults to incremental for local dev This should significantly speed up Rust builds by: 1. Caching compiled crates across runs (rust-cache) 2. Caching individual compilation units (sccache with GHA backend) 3. Sharing cache between related jobs via shared-key
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the efficiency of Rust CI builds by implementing robust caching strategies. It introduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request optimizes Rust CI builds by integrating sccache and updates the documentation to guide developers on using it locally. The changes in the README are clear and provide valuable instructions for build caching. I have one suggestion to improve the user-friendliness of the installation instructions by recommending package managers for a faster sccache setup.
This should significantly speed up Rust builds by:
Checklist