Conversation
Summary of ChangesHello @CatherineSue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the development workflow by automating the generation of gRPC/protobuf Python files. Previously, developers had to manually run a script to compile these files. Now, the build system handles this automatically during package installation or development setup, streamlining the process and reducing potential for errors or outdated generated code. This change simplifies dependency management and ensures that the generated files are always up-to-date with the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/tag-and-rerun-ci |
There was a problem hiding this comment.
Code Review
This pull request introduces a new build system to automatically generate Python protobuf and gRPC files from sglang_scheduler.proto during package installation or development. This is accomplished by adding grpcio-tools as a build dependency in pyproject.toml and implementing a custom setup.py that hooks into setuptools commands (build_py, develop, egg_info) to compile the .proto file and fix generated import paths. Consequently, the previously checked-in generated files (sglang_scheduler_pb2.py, sglang_scheduler_pb2_grpc.py, and their type stubs) are removed from the repository and added to .gitignore. Review feedback suggests improving the robustness of the subprocess.run command construction by passing arguments as a list instead of a shlex.split string, and removing a misleading FileNotFoundError exception handler in setup.py as grpcio-tools issues are already covered by the command's exit code check.
|
/rerun-failed-ci |
- Add setup.py with custom build hooks (build_py, develop, egg_info) to compile .proto files automatically during install - Add grpcio-tools to build-system.requires in pyproject.toml - Remove pre-generated protobuf files from version control - Add generated *_pb2.py, *_pb2_grpc.py, *_pb2.pyi to .gitignore This follows the pattern used by vllm-tgis-adapter and eliminates the need to manually run compile_proto.py. The protobuf files are now generated at build time for both regular and editable installs.
…roject#16409)" This reverts commit 1688023.
setup.pywith custom build hooks (build_py,develop,egg_info) to compile .proto files automatically during installgrpcio-toolstobuild-system.requiresinpyproject.toml*_pb2.py,*_pb2_grpc.py,*_pb2.pyito.gitignoreThis eliminates the need to manually run
compile_proto.py. The protobuf files are now generated at build time for both regular and editable installs.Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.