Skip to content

[model-gateway][grpc] Refactor harmony/responses.rs#16508

Merged
slin1237 merged 1 commit intomainfrom
chang/resp-refactor-2
Jan 5, 2026
Merged

[model-gateway][grpc] Refactor harmony/responses.rs#16508
slin1237 merged 1 commit intomainfrom
chang/resp-refactor-2

Conversation

@CatherineSue
Copy link
Collaborator

@CatherineSue CatherineSue commented Jan 5, 2026

Motivation

harmony/responses.rs has 1658 lines, this PR splits them by creating a harmony/responses module.

Modifications

  • Split the old monolithic responses.rs (~1650 lines) into 6 focused files
  • Fixed import path for RequestPipeline (routers::grpc::pipeline not harmony::pipeline)
  • Made ToolResult public for use by common/responses/streaming.rs
  • Exported ToolResult from responses/mod.rs
  • Code compiles cleanly with no clippy warnings

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

Changes made:

  - Split the old monolithic responses.rs (~1650 lines) into 6 focused files
  - Fixed import path for RequestPipeline (routers::grpc::pipeline not harmony::pipeline)
  - Made ToolResult public for use by common/responses/streaming.rs
  - Exported ToolResult from responses/mod.rs
  - Code compiles cleanly with no clippy warnings
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@slin1237 slin1237 merged commit 454dc9e into main Jan 5, 2026
72 checks passed
@slin1237 slin1237 deleted the chang/resp-refactor-2 branch January 5, 2026 18:21
sunxxuns pushed a commit to sunxxuns/sglang that referenced this pull request Jan 5, 2026
jamesjxliu pushed a commit to jamesjxliu/sglang that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments