Conversation
Key Changes 1. Moved files from openai/ into openai/responses/ subdirectory 2. Extracted handle_non_streaming_response() from router.rs to responses/non_streaming.rs 3. Created common.rs with shared SSE helpers used by both streaming and accumulator 4. Removed unused re-exports of Provider, ProviderError, ProviderRegistry 5. Updated documentation in openai_mcp_flow.md
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
slin1237
approved these changes
Jan 5, 2026
jamesjxliu
pushed a commit
to jamesjxliu/sglang
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
openai router module has the following problems:
route_responses()is 270 lines of inline logic (830-1097)Compare to gRPC's
route_responses_impl()(~50 lines):handle_non_streaming_response()is inline in router.rs (371-491)This 120-line function should be in a separate file like Harmony's non_streaming.rs.
accumulator.rs──imports──>streaming.rs(extract_output_index,get_event_type)These helpers should be in a common utilities file, not
streaming.rs.Modifications
1. Moved files from openai/ into
openai/responses/subdirectory2. Extracted
handle_non_streaming_response()fromrouter.rstoresponses/non_streaming.rs3. Created
common.rswith shared SSE helpers used by both streaming and accumulator4. Removed unused re-exports of
Provider, ProviderError, ProviderRegistryAccuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.