Skip to content

[router] Remove deadcode and add note for unused API completeness methods#16528

Merged
slin1237 merged 1 commit intomainfrom
chang/cleanup-3
Jan 6, 2026
Merged

[router] Remove deadcode and add note for unused API completeness methods#16528
slin1237 merged 1 commit intomainfrom
chang/cleanup-3

Conversation

@CatherineSue
Copy link
Collaborator

@CatherineSue CatherineSue commented Jan 6, 2026

Motivation

This PR removes unused fields that are not for API completeness in routers module.

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@CatherineSue CatherineSue changed the title [router] Remove deadcode and move unused API completeness methods [router] Remove deadcode and add note for unused API completeness methods Jan 6, 2026
@slin1237 slin1237 merged commit 4cf2bbd into main Jan 6, 2026
63 checks passed
@slin1237 slin1237 deleted the chang/cleanup-3 branch January 6, 2026 03:53
jamesjxliu pushed a commit to jamesjxliu/sglang that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments