Skip to content

[grpc] Unify ResponsesContext and HarmonyResponsesContext#16549

Merged
slin1237 merged 1 commit intomainfrom
chang/resp-refactor-6
Jan 6, 2026
Merged

[grpc] Unify ResponsesContext and HarmonyResponsesContext#16549
slin1237 merged 1 commit intomainfrom
chang/resp-refactor-6

Conversation

@CatherineSue
Copy link
Collaborator

@CatherineSue CatherineSue commented Jan 6, 2026

Motivation

ResponsesContext only differs with HarmonyResponsesContext in backgroud_tasks, which is not actually used anywhere. cancel_response depends on it but it will fail at the first step.

Modifications

  • Move ResponsesContext to common/context.rs
  • Remove backgroud_tasks in ResponsesContext
  • Remove HarmonyResponsesContext
  • Update cancel_response_impl logic to indicate it is not supported.

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@slin1237 slin1237 merged commit 21da2dc into main Jan 6, 2026
74 of 75 checks passed
@slin1237 slin1237 deleted the chang/resp-refactor-6 branch January 6, 2026 15:28
1994 pushed a commit to 1994/sglang that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments