[smg][ci]: migrate benchmarks to e2e_test/benchmarks/, use parent conftest#16597
Merged
[smg][ci]: migrate benchmarks to e2e_test/benchmarks/, use parent conftest#16597
Conversation
slin1237
requested review from
CatherineSue,
Fridge003,
Kangyan-Zhou,
ispobock,
key4ng and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
CatherineSue
reviewed
Jan 6, 2026
| model_path=model_path, | ||
| experiment_folder=f"benchmark_cache_aware_regular_{backend}", | ||
| thresholds={ | ||
| "ttft_mean_max": 6, |
Collaborator
Author
There was a problem hiding this comment.
came out of thin air
no logical reason behind this
which is a problem lol
we need to address this
slin1237
force-pushed
the
smg-ci-n/15
branch
7 times, most recently
from
2231bcc to
4bd6929
Compare
…ftest - rename router-http-tests to router-benchmark-tests, use e2e_test/benchmarks - clean up genai_bench_runner with BenchmarkResult dataclass - add GPUMonitor class
michaelzhang-ai
pushed a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.