fix(e2e_test): remove dead code and fix type annotations

[slin1237]

• Remove unused constants in utils.py (DEFAULT_TIMEOUT, DEFAULT_PORT_BASE, etc.)
• Remove unused skip_if_no_gpu() function in utils.py
• Fix type annotation: any -> Any in conftest.py
• Fix type annotation: List[str] -> list[str] in simple_eval_common.py

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
4. After green CI and required approvals, ask Merge Oncalls to merge.

[gemini-code-assist]

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability and clarity of the e2e_test suite by removing obsolete code and updating type annotations to align with current Python best practices. These changes streamline the codebase, making it easier to understand and less prone to potential issues related to unused definitions or outdated type hints.

Highlights

• Dead Code Removal: Several unused constants, including DEFAULT_TIMEOUT, DEFAULT_STARTUP_TIMEOUT, DEFAULT_PORT_BASE, STDOUT_FILENAME, and STDERR_FILENAME, have been removed from sgl-model-gateway/e2e_test/utils.py.
• Unused Function Removal: The skip_if_no_gpu() function, which was no longer utilized, has been removed from sgl-model-gateway/e2e_test/utils.py.
• Type Annotation Modernization (conftest.py): Type annotations in sgl-model-gateway/e2e_test/conftest.py have been updated from the built-in any to the typing.Any type for better static analysis and adherence to modern Python type hinting standards.
• Type Annotation Modernization (simple_eval_common.py): Type annotations in sgl-model-gateway/e2e_test/infra/simple_eval_common.py have been updated from typing.List[str] to the more concise list[str] as per Python 3.9+ type hinting syntax.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request focuses on cleaning up the e2e test suite by removing dead code and fixing type annotations. The changes include removing unused constants and a function in utils.py, and correcting type hints from any to Any and List[str] to list[str] in conftest.py and simple_eval_common.py respectively. My review confirms these changes are beneficial for code quality. I have one suggestion to avoid a magic number by using a local constant, which improves readability and maintainability.